<html>
<head><meta charset="utf-8"><title>queue is almost empty · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html">queue is almost empty</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="162130656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162130656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162130656">(Mar 30 2019 at 17:26)</a>:</h4>
<p>hey <span class="user-group-mention" data-user-group-id="492">@T-compiler</span>  -- the bors queue is almost empty... y'all need to r+ some more :P</p>



<a name="162130669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162130669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162130669">(Mar 30 2019 at 17:26)</a>:</h4>
<p>Haven't had that problem in a while</p>



<a name="162130689"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162130689" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162130689">(Mar 30 2019 at 17:27)</a>:</h4>
<p>That's new</p>



<a name="162130784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162130784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162130784">(Mar 30 2019 at 17:29)</a>:</h4>
<p>its what you get when you don't have 259 problems and the power of rollups</p>



<a name="162131406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162131406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162131406">(Mar 30 2019 at 17:44)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> You can review <a href="https://github.com/rust-lang/rust/pull/59517" target="_blank" title="https://github.com/rust-lang/rust/pull/59517">https://github.com/rust-lang/rust/pull/59517</a> =P</p>



<a name="162131414"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162131414" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162131414">(Mar 30 2019 at 17:45)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> I can rubber stamp, I cannot review ;)</p>



<a name="162131435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162131435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162131435">(Mar 30 2019 at 17:45)</a>:</h4>
<p>That doesn't sound right. Everyone can review, only the compiler team can rubber stamp? =P</p>



<a name="162131484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162131484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162131484">(Mar 30 2019 at 17:46)</a>:</h4>
<p>+1,274 −2,316 <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="162132619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162132619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162132619">(Mar 30 2019 at 18:10)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span>   <span class="user-mention" data-user-id="124288">@oli</span> can review your PR tho ;)</p>



<a name="162132632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162132632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162132632">(Mar 30 2019 at 18:11)</a>:</h4>
<p>I still have 90 new notifications since yesterday, I may not get to reviews until tomorrow or tuesday</p>



<a name="162222345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162222345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162222345">(Apr 01 2019 at 09:29)</a>:</h4>
<p>I am pleased to say that the queue is entirely empty now and has been for hours.</p>



<a name="162222479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162222479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162222479">(Apr 01 2019 at 09:30)</a>:</h4>
<p>all that wasted money :(</p>



<a name="162222516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162222516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162222516">(Apr 01 2019 at 09:31)</a>:</h4>
<p>Yeah; start r+ing folks</p>



<a name="162222749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162222749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162222749">(Apr 01 2019 at 09:35)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span>  perhaps this is a good time to rustfmt?</p>



<a name="162244528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162244528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162244528">(Apr 01 2019 at 14:36)</a>:</h4>
<p>perhaps revive <a href="https://github.com/rust-lang/rust/issues/58702" target="_blank" title="https://github.com/rust-lang/rust/issues/58702">#58702</a> first <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="162247902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162247902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162247902">(Apr 01 2019 at 15:13)</a>:</h4>
<p><span class="user-mention" data-user-id="125254">@kennytm</span> waiting on boostrap changes</p>



<a name="162258613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162258613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162258613">(Apr 01 2019 at 17:12)</a>:</h4>
<blockquote>
<p>perhaps this is a good time to rustfmt?</p>
</blockquote>
<p>By the way, the primary issue with trailing expressions that I was complaining about in <a href="https://internals.rust-lang.org/t/running-rustfmt-on-rust-lang-rust-and-other-rust-lang-repositories/8732/72" target="_blank" title="https://internals.rust-lang.org/t/running-rustfmt-on-rust-lang-rust-and-other-rust-lang-repositories/8732/72">https://internals.rust-lang.org/t/running-rustfmt-on-rust-lang-rust-and-other-rust-lang-repositories/8732/72</a> is fixed now (only in rustfmt 2.0 mode though).</p>



<a name="162258705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162258705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162258705">(Apr 01 2019 at 17:13)</a>:</h4>
<p>(I still think this formatting thing needs a test run on a single crate though, to get experience with the process.)</p>



<a name="162261530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162261530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162261530">(Apr 01 2019 at 17:48)</a>:</h4>
<blockquote>
<p>only in rustfmt 2.0 mode</p>
</blockquote>
<p>TIL — what is this?</p>



<a name="162276812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162276812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162276812">(Apr 01 2019 at 20:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116155">@Jake Goulding</span> <br>
<code>version = "Two"</code> in rustfmt.toml</p>



<a name="162276912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162276912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162276912">(Apr 01 2019 at 20:40)</a>:</h4>
<p>rustfmt attempts to avoid changing formatting in stable releases</p>



<a name="162277333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162277333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162277333">(Apr 01 2019 at 20:44)</a>:</h4>
<p>Hm. It's not obviously documented on the README; is there somewhere more official I should be reading to learn about what settings that implies?</p>



<a name="162277387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162277387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162277387">(Apr 01 2019 at 20:45)</a>:</h4>
<p>It's mentioned in <a href="https://github.com/rust-lang/rustfmt/blob/master/Configurations.md" target="_blank" title="https://github.com/rust-lang/rustfmt/blob/master/Configurations.md">https://github.com/rust-lang/rustfmt/blob/master/Configurations.md</a></p>



<a name="162277432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/queue%20is%20almost%20empty/near/162277432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/queue.20is.20almost.20empty.html#162277432">(Apr 01 2019 at 20:45)</a>:</h4>
<p>Ugh. That should <em>probably</em> be exposed in the playground in some manner...</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>